Skip to content

Replace kafka.RecordMetadata with a common ResultMetadata #5217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2022
Merged

Replace kafka.RecordMetadata with a common ResultMetadata #5217

merged 2 commits into from
May 10, 2022

Conversation

jiangpengcheng
Copy link
Contributor

Replace RecordMetadata with ResultMetadata

Description

Replace RecordMetadata with ResultMetadata to make MessageProducer independent of kafka

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@ningyougang
Copy link
Contributor

Great!

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2022 •
edited
Loading

Codecov Report

Merging #5217 (e8dd1f6) into master (3e3414c) will increase coverage by 28.34%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           master    #5217       +/-   ##
===========================================
+ Coverage   44.49%   72.83%   +28.34%     
===========================================
  Files         238      238               
  Lines       13957    13956        -1     
  Branches      570      565        -5     
===========================================
+ Hits         6210    10165     +3955     
+ Misses       7747     3791     -3956
Impacted Files Coverage Δ
...apache/openwhisk/connector/lean/LeanProducer.scala 0.00% <0.00%> (ø)
.../org/apache/openwhisk/core/connector/Message.scala 76.28% <ø> (+12.37%) ⬆️
...enwhisk/core/loadBalancer/InvokerSupervision.scala 90.27% <0.00%> (+90.27%) ⬆️
...e/loadBalancer/ShardingContainerPoolBalancer.scala 78.53% <ø> (+78.53%) ⬆️
...ontainerpool/v2/FunctionPullingContainerPool.scala 80.32% <ø> (ø)
...nwhisk/core/invoker/ContainerMessageConsumer.scala 78.72% <ø> (+78.72%) ⬆️
...he/openwhisk/core/invoker/FPCInvokerReactive.scala 0.00% <ø> (ø)
...whisk/connector/kafka/KafkaProducerConnector.scala 60.97% <100.00%> (-19.03%) ⬇️
...enwhisk/core/loadBalancer/CommonLoadBalancer.scala 71.42% <100.00%> (+71.42%) ⬆️
.../openwhisk/core/loadBalancer/FPCPoolBalancer.scala 33.73% <100.00%> (ø)
... and 142 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3414c...e8dd1f6. Read the comment docs.

style95
style95 approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@style95 style95 merged commit cbdcfe5 into apache:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@style95 style95 style95 approved these changes

@ningyougang ningyougang ningyougang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiangpengcheng @ningyougang @codecov-commenter @style95